Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description of view_controller_chains #1094

Merged
merged 4 commits into from
Aug 7, 2023
Merged

Update description of view_controller_chains #1094

merged 4 commits into from
Aug 7, 2023

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Aug 7, 2023 •
edited
Loading

Update the docs with the current output and adds a hint where the PDF is saved.

@codecov-commenter
Copy link

Codecov Report

Merging #1094 (be4237a) into master (925f5f3) will decrease coverage by 2.21%.
Report is 504 commits behind head on master.
The diff coverage is 34.83%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
- Coverage   34.61%   32.41%   -2.21%     
==========================================
  Files          52       94      +42     
  Lines        2981     9937    +6956     
  Branches     1855     6694    +4839     
==========================================
+ Hits         1032     3221    +2189     
- Misses        310      789     +479     
- Partials     1639     5927    +4288
Flag Coverage Δ
unittests 32.41% <34.83%> (-2.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
controller_manager/src/controller_manager.cpp 37.94% <ø> (-1.77%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 46.76% <ø> (-6.87%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.42% <ø> (ø)
... and 70 more

... and 20 files with indirect coverage changes

@bmagyar bmagyar added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Aug 7, 2023
@bmagyar bmagyar merged commit bda7337 into ros-controls:master Aug 7, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Aug 7, 2023
@christophfroehlich @mergify
Add info where the pdf is saved to view_controller_chains (#1094)
5069114 
(cherry picked from commit bda7337)
@mergify mergify bot mentioned this pull request Aug 7, 2023
Merged
@christophfroehlich christophfroehlich deleted the christophfroehlich-patch-1 branch August 7, 2023 10:52
bmagyar pushed a commit that referenced this pull request Aug 7, 2023
@mergify
Add info where the pdf is saved to view_controller_chains (#1094) (#1096
2189b97 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@destogl destogl Awaiting requested review from destogl

@harderthan harderthan Awaiting requested review from harderthan

@jaron-l jaron-l Awaiting requested review from jaron-l

@sachinkum0009 sachinkum0009 Awaiting requested review from sachinkum0009

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophfroehlich @codecov-commenter @bmagyar